Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple types shall not be treated like references #7

Open
pixellos opened this issue Oct 27, 2023 · 1 comment
Open

Simple types shall not be treated like references #7

pixellos opened this issue Oct 27, 2023 · 1 comment

Comments

@pixellos
Copy link

pixellos commented Oct 27, 2023

image

Types like:

  • number
  • string
  • null
  • undefined

should not be candidate for Memo, as they're not referencial types.

image
(Only colSpan is incorrect in this sample, the style object is highlighted correctly ofc)

Number / string consts should not be treated like error, concatenations as well (if the concatenation parts are stable)

@pixellos
Copy link
Author

Also, when we're iterating throu list, and creating elements, if the array is stable, and elements are stable, we should be able to use props without warning

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant