Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow options under "steal" #164

Closed
matthewp opened this issue Jul 1, 2016 · 4 comments
Closed

Allow options under "steal" #164

matthewp opened this issue Jul 1, 2016 · 4 comments
Assignees

Comments

@matthewp
Copy link
Member

matthewp commented Jul 1, 2016

Keep "system" for backwards compat, but allow "steal" to be the package.json object. No difference otherwise.

@mjstahl
Copy link

mjstahl commented Jul 19, 2016

Per conversation with @matthewp today.

Add a helper function to npm-utils.js. Something like:

utils.config = (pkg) => return pkg.steal || pkg.system;

Then update the all the code to use the util function as opposed to accessing the pkg.system property directly.

Also update all of the steal docs, and READMEs.

@mjstahl mjstahl self-assigned this Jul 21, 2016
@pYr0x
Copy link

pYr0x commented Jul 29, 2016

@mjstahl is there a working branch i can also worked on?

@mjstahl
Copy link

mjstahl commented Jul 29, 2016

@pYr0x No sir there is not, so if you wanna go ahead and start one. Be my guest. Haven't had a chance to get to it yet.

@pYr0x pYr0x self-assigned this Aug 12, 2016
@matthewp matthewp added the p0 label Oct 19, 2016
@matthewp matthewp assigned matthewp and unassigned mjstahl and pYr0x Oct 20, 2016
matthewp added a commit that referenced this issue Oct 20, 2016
This moves configuration to a "steal" object in package.json and
deprecates the use of "system". "system" will still be allowed going
forward for backwards compatibility the same way "jam" and whatnot is.

Closes #164
@matthewp
Copy link
Member Author

Closed by #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants