Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors dynamicTypeMaxSize to take in a CGFloat instead of a hardcoded enum value.
Other additions:
It occurred to me while putting up this PR that another option we have for supporting DynamicTypeSize without having users input arbitrary values for their maxFont size is to simply apply the same increments/decrements to base font size as done by apple shown here. That way scaling aligns with how the OS handles it. Only problem there is if Apple ever makes adjustments to the table they would have to be reflected here as well.
Example:
Let me know what you think @brendanlensink