[11] Add NiceTextField #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move some things from niceButton into NiceButtonStyle to accomadate sharing them with NiceTextField
|
@AZielinsky95 just noticed this never got merged 😅 any reason to not just merge it now? |
AZielinsky95
approved these changes
Jan 25, 2024
Comment on lines
108
to
109
| .padding(.top, text.isEmpty ? 16 : 8) | ||
| .padding(.bottom, text.isEmpty ? 16 : 8) |
There was a problem hiding this comment.
Nitpick: can be reduced to 1 line using .vertical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11
This PR adds a new UI element - a Nice text field!
There's certainly some iterating to be done here, but I think this gives us a decent foundation to start with. It supports all the basic stuff we usually want like secure entry, different keyboards, etc and a decent amount of styling by piggy-backing on a lot of the button styling options.