Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gifts have a "View on Steam Database" button that is always greyed out #15

Closed
KarlCastle opened this issue Dec 23, 2017 · 2 comments
Closed
Labels

Comments

@KarlCastle
Copy link
Contributor

The button is created disabled and the segment of code that is intended to enable it has a bug that stops it from completing:

/gifts/undefined/validateunpack
Failed to load resource: the server responded with a status of 404 (Not Found)
inventory.js:316

I'm guessing the structure of the asset/item from CInventory changed so item.description.id is now item.assetid and PopulateActions in inventory.js hasn't been updated?

@xPaw
Copy link
Member

xPaw commented Dec 23, 2017

Do you want to make a PR fixing this?

@xPaw xPaw added the bug label Dec 23, 2017
KarlCastle added a commit to KarlCastle/BrowserExtension that referenced this issue Dec 23, 2017
@xPaw xPaw closed this as completed in #16 Dec 23, 2017
@KarlCastle
Copy link
Contributor Author

Yes, I'm new to Git so I think I've clicked all the right buttons. Loading as an unpacked extension this PR has the button enable and when clicked takes me to the correct page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants