Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for installation of plugin from remote git repository #40

Closed
ghost opened this issue Apr 21, 2022 · 6 comments
Closed

Add support for installation of plugin from remote git repository #40

ghost opened this issue Apr 21, 2022 · 6 comments
Labels
enhancement New feature or request feature request a request for a feature, no guarantee of addition

Comments

@ghost
Copy link

ghost commented Apr 21, 2022

It would be useful for installation and updating if users could simply enter a url to a github or gitlab repository to install a plugin.

@marios8543 marios8543 added the enhancement New feature or request label Apr 24, 2022
@TrainDoctor TrainDoctor added the feature request a request for a feature, no guarantee of addition label Jun 1, 2022
@TrainDoctor
Copy link
Member

This is under consideration by the team. No more information at this time.

@milroneth
Copy link

Based on Discord discussion on this, I like the idea of the URL bar. Would work by providing a GitHub repo URL which it will git clone.

Since devs asked for specific branches too, the easy way to implement without adding selector menus, having to read branches form the site, etc. would be to provide the branch URL directly, then the loader would just have to split the string and run a couple extra commands, scaffold code would look like:

Input: https://github.com/DevName/PluginName/tree/branchName

git clone $input
if $branchName {
  cd $PluginName
  git checkout $branchName
}

Sounds quick and easy, without much complexity.

@Wolvan
Copy link

Wolvan commented Jun 2, 2022

Addition to @milroneth's comment, which I am very much in favor of by the way:
You can directly check out a specific branch during cloning by providing git with the -b <branch-name> parameter during clone, no additional checkout needed.
(Example: git clone -b dev https://github.com/Wolvan/spdck.git /home/deck/homebrew/plugins/spdck)

@JohnnyCrazy
Copy link
Member

Not sure how this aligns with our idea of react plugins.

As soon as we ship react-based plugins, all plugins will have some kind of build step involved, converting JSX/TSX to JS and bundling all other possible dependencies. Since you normally don't want to store these "build" artifacts in the repo itself, branches are not runnable by default.

@TrainDoctor
Copy link
Member

Not sure how this aligns with our idea of react plugins.

As soon as we ship react-based plugins, all plugins will have some kind of build step involved, converting JSX/TSX to JS and bundling all other possible dependencies. Since you normally don't want to store these "build" artifacts in the repo itself, branches are not runnable by default.

I have to agree unfortunately. I think we should move this to a URL that will support different repositories releases as already compiled code/binaries as the way to address this problem.

@TrainDoctor
Copy link
Member

Zip files from URL are now supported in react-frontend-plugins branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request a request for a feature, no guarantee of addition
Projects
None yet
Development

No branches or pull requests

5 participants