Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context-aware escaping #14

Closed
DemiMarie opened this issue Jun 20, 2017 · 3 comments
Closed

Context-aware escaping #14

DemiMarie opened this issue Jun 20, 2017 · 3 comments

Comments

@DemiMarie
Copy link

This is necessary to be able to safely e.g., have colors for elements that are determined at runtime. It is also necessary to support proper URL handling.

@Stebalien
Copy link
Owner

Can you give me some concrete examples? The current escaping should be sufficient for HTML text nodes and HTML attributes (the scope of horrorshow).

@DemiMarie
Copy link
Author

https://security.googleblog.com/2009/03/reducing-xss-by-way-of-automatic.html

So dynamically-chosen colors and URLs.

@Stebalien
Copy link
Owner

I see. Those issues are well beyond the scope of horrorshow. Basically, horrorshow-level escaping prevents potentially user-specified strings from messing with the HTML document's structure but nothing more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants