Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light mode #11

Closed
invaders-xx opened this issue Apr 14, 2022 · 6 comments
Closed

Dark/Light mode #11

invaders-xx opened this issue Apr 14, 2022 · 6 comments

Comments

@invaders-xx
Copy link

Hi,

Many thanks for this package. It would be great if the banner style automatically switches when filament dark mode is enabled and toggled.

@jszobody
Copy link
Member

The auto-injected banner is dark by default. I just added a bottom-border so that it looks a bit better above the rest of the UI:

CleanShot 2022-04-29 at 08 36 18@2x

That what you had in mind?

@Saifallak
Copy link
Contributor

@jszobody nope, i guess he means the banner toggles light/dark with filament

@jszobody
Copy link
Member

jszobody commented Apr 29, 2022

@Saifallak I designed the banner to be "dark" all the time by default. Even when filament is in light mode, the impersonation banner at the top is dark. So what's there to toggle? I can't imagine you'd want the banner to be light when filament goes dark??

@Saifallak
Copy link
Contributor

nope i meant when :

  • filment is dark the banner is dark

image

  • and when filment is light, the banner is light.
    image

@jszobody
Copy link
Member

jszobody commented Nov 7, 2022

Happy to review a PR if someone wants to take a stab, going to close this for now.

@jszobody jszobody closed this as completed Nov 7, 2022
@jszobody
Copy link
Member

This is now done in 2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants