-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request urls #7
Comments
Maybe in File::make() when providing a local file you can change the if statement to |
The more I think about this it appears that you had support for this before creating TempFile and lost it then. |
Supporting URLs is tricky. We need to know the size of the source up front, to calculate the total zip filesize. This is done before any file contents are retrieved. While some URLs would provide a That's why so far I've only added support for s:// paths, since we can use the AWS API to lookup the size for those. |
Thank you for the explanation. That makes sense. |
Thank you for the package.
I am trying to include a file from s3 in my zip. I noticed the link gets included as text. The thing is I only have access to a temporary url, which starts with http://, rather than s3://.
Would it be possible that File::make() autodetects URLs and streams them, rather than including them as textual content?
Since fopen() can be used for files and URLs I assume the UrlFile would look similar to LocalFile.
The text was updated successfully, but these errors were encountered: