Add address sanitizer (ASAN) support (fix #1002) #1004
Conversation
| @@ -117,7 +122,7 @@ AS_IF([test "x$enable_docs" != "xno"],[ | |||
| ***************************************************************** | |||
| * Ruby dependencies for building jq documentation not found. * | |||
| * You can still build, install and hack on jq, but the manpage * | |||
| * will not be rebuilt and some of the tests won't run. * | |||
There was a problem hiding this comment.
Ah, I meant to commit this separately. This fixes vim syntax mis-highlighting.
|
OK, I think it's ready. ASAN is fast enough that one can run with it compiled-in in many cases. I could see releasing executables with and without ASAN. |
|
OTOH, it's not as good as valgrind... |
| dnl Running tests with Valgrind is slow; address sanitizer (ASAN) is | ||
| dnl faster. | ||
| AC_ARG_ENABLE([asan], | ||
| AC_HELP_STRING([--enable-asn], [enable address sanitizer])) |
|
Does asan catch anything valgrind does not? If so, we should run a fourth travis build with asan instead of valgrind. |
|
From what I can tell, no, it catches a subset of the classes of errors that valgrind catches. For example, it doesn't catch reads of uninitialized memory. I'm thinking this is useful when there's no valgrind, or -because it's faster than valgrind- during development prior to sending a PR. |
|
Okay. Looks good once you fix the typo. |
|
Thanks. |
No description provided.