Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1-indexed numbers for invalid ranges? #147

Closed
Arcanemagus opened this issue Sep 9, 2016 · 3 comments
Closed

Use 1-indexed numbers for invalid ranges? #147

Arcanemagus opened this issue Sep 9, 2016 · 3 comments

Comments

@Arcanemagus
Copy link
Collaborator

Should the error messages show 1-indexed values instead of 0-indexed? When I originally wrote the message I was only thinking about linter package authors, but it's users that most often see the message so it might make more sense to use 1-indexed values.

@steelbrain
Copy link
Owner

If it shows 1-indexed numbers for invalid ranges, it'll actually only add to the confusion. As the developers will not know if it's 0-indexed or 1-indexed. At least I would be

@steelbrain
Copy link
Owner

How about a hint in the message saying that the range displayed is a 0-indexed one?

@Arcanemagus
Copy link
Collaborator Author

This is getting trapped and handled differently by providers handling this "nicely" so it's not really relevant there, I think this is fine as is since we are requiring 0-indexed values to be input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants