-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only invoke flow after hyperclick word is clicked #105
Comments
I'm loosely against that. I don't know if flow's word boundaries are the same as Atom's - it also doesn't give you the underlining feedback of whether something is clickable. Let me look at #103 - I have a few thoughts. |
@steelbrain - My initial theory is that https://github.com/steelbrain/flow-ide/blob/master/lib/index.js#L58 won't find a |
Confirmed. |
I have found a lot of places where flow fails to go to the definition. Marking these spots as clickable would then lead to issues in our repo again. |
Here's the issue that got filed with flow - facebook/flow#4445 - they haven't responded (possibly because it's closed) so maybe open up a new one with the same question? |
Pushing the PR that changes search path order should allow folks to workaround the issue by invoking |
We could use Atom APIs to get word boundary at a range and by default show it as clickable, and after the user clicks it we can invoke Flow to jump for us
Fixes #103
Thoughts @leos @lloiser?
The text was updated successfully, but these errors were encountered: