Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Require a 'force' option when overriding service arguments #36

Closed
ccheetham opened this issue Oct 12, 2018 · 1 comment
Closed

Require a 'force' option when overriding service arguments #36

ccheetham opened this issue Oct 12, 2018 · 1 comment
Labels
accepted enhancement New feature or request
Milestone

Comments

@ccheetham
Copy link
Contributor

If a service already has existing arguments, the user should be required to indicate intent to replacing them.

E.g. assume a SQL Server service named database with defined docker launch args:

$ st add database mssql-server
$ st args docker database -- -e ACCEPT_EULA=y
Set the 'docker' deployment environment argument(s) for service 'database' to '-e ACCEPT_EULA=y'

The following should fail, but currently it simply overwrites existing args:

$ st args docker database -- -e ACCEPT_EULA=n
Set the 'docker' deployment environment argument(s) for service 'database' to '-e ACCEPT_EULA=n'

A better behavior would be something like:

$ st args docker database -- -e ACCEPT_EULA=n
'docker' deployment environment argument(s) for service 'database' already exist.
Run with '--force' to replace.
$ st args docker database --force -- -e ACCEPT_EULA=n
Set the 'docker' deployment environment argument(s) for service 'database' to '-e ACCEPT_EULA=n'
@ccheetham ccheetham added the enhancement New feature or request label Oct 12, 2018
@ccheetham ccheetham added this to the 1.0.0 milestone Oct 12, 2018
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/161183553

The labels on this github issue will be updated when the story is started.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants