Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail not showing up #1499

Closed
TimCliff opened this issue Jun 20, 2017 · 12 comments
Closed

Thumbnail not showing up #1499

TimCliff opened this issue Jun 20, 2017 · 12 comments

Comments

@TimCliff
Copy link
Contributor

The thumbnail for this user's post is not showing up. Multiple users see the same thing.

https://steemit.com/@mobbs
image

The image URL for the top image is:
https://steemitimages.com/0x0/https://steemitimages.com/DQmRYMxoQS3JoeCz9sSNd7bhvJZhNPjEyNMs6n97RerjJ58/%23WILTW%20(3).png

Here is the json_metadata from steemd:
{"tags":["blog","science","life","writing","steemit"],"users":["suesa"],"image":["https://steemitimages.com/DQmRYMxoQS3JoeCz9sSNd7bhvJZhNPjEyNMs6n97RerjJ58/%23WILTW%20(3).png","https://steemitimages.com/DQmZSiUBnad9oVipAg4pwYgrEcRzGW5Tgz1RNLDhFPZmVF5/image.png","https://steemitimages.com/DQmWixodh2c5yFruWur317SEWC1AKapj9fjsrXoBbPAwDWD/image.png","https://steemitimages.com/DQmctA5QaRe9V57GZuLbWTXCRJxVYbsYsZyZXXFHtHEY8iY/image.png","https://steemitimages.com/DQmQCeKNKjPYSutpbTRXbEnHhkDEr8ec2KyaFBBDK2w8ucR/image.png","https://steemitimages.com/DQmRdNtuiy9iREK4Repj7W2akCBLWkJtzDcEEZVWzoxA2ap/image.png","https://steemitimages.com/DQmazA4PGNanPYPiNPQbMNcBhFYMxZWf2S7XHksw722NNH9/image.png","https://steemitimages.com/DQmTS7g5bMmbo3vin2we2V3bzmfSzuy2ZE1G9M2a6LYdgoy/image.png","https://steemitimages.com/DQmPSqDHoQYh9GwdN5ufqhfGJ6wUKdnZqfGozCoFaAoN2Xw/image.png"],"links":["https://steemit.com/fiction/@suesa/killed-by-the-resistance-how-we-lost-the-antibiotics","https://www.nature.com/news/resistance-to-last-ditch-antibiotic-has-spread-farther-than-anticipated-1.22140","https://www.newscientist.com/article/2133476-the-strange-cook-pine-trees-that-always-lean-towards-the-equator/","http://www.sciencemag.org/news/2017/06/china-s-quantum-satellite-achieves-spooky-action-record-distance","http://www.investopedia.com/news/how-china-became-worlds-biggest-innovator/","http://all-that-is-interesting.com/interesting-events/3","http://www.patheos.com/blogs/friendlyatheist/2017/06/18/no-breatharians-cant-live-without-food-and-neither-can-anyone-else/"],"app":"steemit/0.1","format":"markdown"}

@rayadav
Copy link

rayadav commented Jul 5, 2017

@TimCliff not sure what the problem was, but I can see it now:
screen shot 2017-07-05 at 19 44 07

This can be closed.

@TimCliff
Copy link
Contributor Author

TimCliff commented Jul 6, 2017

I had advised the user to rename the image file and re-upload it to update the post, which is probably why it is showing up now. Multiple users have reported similar issues. I am pretty sure there are special characters (like parentheses) that cause issues if they are part of the image file name.

@roadscape
Copy link
Contributor

Please reopen if this happens again

@TimCliff
Copy link
Contributor Author

@roadscape - I cannot reopen the issue, but I think the issue is when the user uploads a file that has parentheses in it, it does not show up as the thumbnail. I've seen a lot of users reporting it, and someone just brought it up again.

image

@roadscape roadscape reopened this Jul 21, 2017
@roadscape
Copy link
Contributor

Thanks, this is a good lead.

@roadscape
Copy link
Contributor

From #1590:

Pretty simple bug: if an image filename contains an apostrophe, it breaks the post thumbnail. The image works in the post just fine though.


It sounds like there might be an issue when we save json_metadata (specifically, image array) when URLs contain special characters like parenthesis or apostrophes. Perhaps URL not being encoded properly.

@plink01001
Copy link
Contributor

Is this still an issue?

@bnchdrff
Copy link
Contributor

def. an issue with how we save json_metadata; we should be urlencoding

@caleblogan
Copy link
Contributor

caleblogan commented Mar 15, 2018

I wasn't able to reproduce this. It looks like special chars are partially url encoded. Here is the post I used: https://steemd.com/test-category/@okc/7lwjqx-test

@TimCliff
Copy link
Contributor Author

I tried with #test 123 ' (4).png and the thumbnail showed up. Not sure if any additional changes are needed.

@TimCliff
Copy link
Contributor Author

@bnchdrff do you still see an issue with the way json_metadata is being saved? If not, I will close this issue because I am unable to reproduce the original problem that was reported.

@plink01001
Copy link
Contributor

Seems resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants