User Reported Issue - SBD -> STEEM Conversions are not showing up in wallet

[TimCliff]

Multiple users have reported SBD -> STEEM conversions are not showing up in the wallet transactions, or in the SBD section.

https://steemd.com/@marcusxman?page=10

https://steemit.com/@marcusxman/transfers

[roadscape]

I don't believe it ever was shown in the steemit wallet. If it's needed, convert_operation should be added here: https://github.com/steemit/steem/blob/20125771e4a8b2eaa7bcbfd1ce993c4c0075e601/contrib/fullnode.config.ini#L16

[roadscape]

From @jamesashton in #1582:

I transferred a small amount of STEEM Dollars, selecting the 'Convert to STEEM' drop down item on the menu that appears next to the STEEM Dollars balance.The STEEM dollar balance is now $0.000 but there is no evidence of the original funds anywhere.Ideally it would show some sort of 'Pending' status, or it would write an entry to the History. Or preferably both.It did say it would take 1-3 days for the transaction to complete. Which is fine, but I can have forgotten about this in 3 days, so there should be some indication that the transaction is in progress.

[TimCliff]

Adding a link to a previous issue where this was implemented/fixed before: #1246

[TimCliff]

@roadscape - I went to fix this, and realized it is already working on a fresh condenser instance. I ran the 'traditional' (non-docker) build steps in GitHub and ran in production mode.

Here is the output in the wallet for my test user with a conversion in progress:

Do you know what would be different on the steemit.com instance?

Here is the code from UserWallet.jsx:

        const currentTime = (new Date()).getTime();
        const conversions = account.get('other_history', List()).reduce( (out, item) => {
            if(item.getIn([1, 'op', 0], "") !== 'convert') return out;

            const timestamp = new Date(item.getIn([1, 'timestamp'])).getTime();
            const finishTime = timestamp + (86400000 * 3.5); // add 3.5day conversion delay
            if(finishTime < currentTime) return out;

            const amount = parseFloat(item.getIn([1, 'op', 1, 'amount']).replace(" SBD", ""));
            conversionValue += amount;

            return out.concat([
                <div key={item.get(0)}>
                    <Tooltip t={tt('userwallet_jsx.conversion_complete_tip') + ": " + new Date(finishTime).toLocaleString()}>
                        <span>(+{tt('userwallet_jsx.in_conversion', {amount: numberWithCommas('$' + amount.toFixed(3))})})</span>
                    </Tooltip>
                </div>
            ]);
        }, []);

[roadscape]

Probably, convert_operation needs to be added here: https://github.com/steemit/steem/blob/20125771e4a8b2eaa7bcbfd1ce993c4c0075e601/contrib/fullnode.config.ini#L16

[TimCliff]

Sorry, I see now that you knew the answer to my question before I even asked it :)

[roadscape]

The op has been added into the whitelist; this issue will be resolved w/ the next prod deploy of steemd.