Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get DTube thumbnail images larger #2409

Closed
pkattera opened this issue Jan 26, 2018 · 7 comments
Closed

get DTube thumbnail images larger #2409

pkattera opened this issue Jan 26, 2018 · 7 comments
Labels

Comments

@pkattera
Copy link
Contributor

The problem

The images that we're pulling from DTube videos are too small. This makes them look awkward in blog posts.

An example of a DTube video in a blog post.

screen shot 2018-01-25 at 10 48 19 pm


An example in the feed within the card layout

screen shot 2018-01-25 at 10 48 45 pm


Potential solutions

Are we able to pull and display a larger image from DTube? I notice that busy.org is able to display larger images for DTube posts.

@pkattera pkattera added the UI label Jan 26, 2018
@roadscape
Copy link
Contributor

(Can this be fixed on dtube's side?)

@sneak sneak changed the title Pull larger images from DTube get DTube thumbnail images larger Feb 20, 2018
@sneak sneak added 2 3 and removed 2 labels Feb 20, 2018
@bonustrack
Copy link

Been talking with Adrien from DTube, he is gonna look for a fix on his side.

@skzap
Copy link

skzap commented Feb 21, 2018

It was already planned to resize these pictures as 200x200 is the minimum for Facebook open graph data (and getting the pic to display in a Facebook feed basically).

Facebook specifies minimum sizes, does steemit do that too?

Anyway fixing on our side doesn’t fix it on yours. If you think this is looking too bad, you should probably just hide like fb.

@bonustrack
Copy link

@skzap I suggest a minimum size of 640 width with a 4/3 aspect ratio, this way the preview image would always appear fullscreen on steemit.com.

@skzap
Copy link

skzap commented Feb 26, 2018

Our images are 16/9 resolution because that's the most mainstream video format and it just makes sense for us. That would end up in 640x360, seems good.

@pkattera
Copy link
Contributor Author

pkattera commented Mar 1, 2018

640x360 at 16/9 is fine for us.
@bonustrack Is there any additional work for us to do, or should this just render nicely once @skzap returns these images at 640x360?

@bonustrack
Copy link

@pkattera no additional work so far to do on condenser, we just need to wait. @skzap told me this will be fixed on the next DTube release (v0.7).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants