Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended diff format while posting a reply #37

Closed
abitmore opened this issue Jul 5, 2016 · 7 comments
Closed

Unintended diff format while posting a reply #37

abitmore opened this issue Jul 5, 2016 · 7 comments

Comments

@abitmore
Copy link

abitmore commented Jul 5, 2016

Here is a reply to my post, the text reads:

How about if they (we - not sure if I'd be classed as a 'large' SP holder) voted an hour after posting? That could act as an extra incentive for early voters.

I think the issue with getting authors to refrain from voting for themselves early, is that some will do it via a proxy/ shill account. Thereby getting the benefit without being perceived to be greedy.

If I reply to this comment with this text:

>How about if they (we - not sure if I'd be classed as a 'large' SP holder) voted an hour after posting? That could act as an extra incentive for early voters.

I support this.

>I think the issue with getting authors to refrain from voting for themselves early, is that some will do it via a proxy/ shill account. Thereby getting the benefit without being perceived to be greedy.

It's all about reputation. Technically it's unable to prevent anyone from voting for herself/himself early.

The result shows as:

@@ -1,8 +1,9 @@
+%3E
How abou
@@ -154,16 +154,34 @@
oters.%0A%0A
+I support this.%0A%0A%3E
I think
@@ -373,8 +373,117 @@
greedy.
+%0A%0AIt's all about reputation. Technically it's unable to prevent anyone from voting for herself/himself early.

Link is here.

@jcalfee
Copy link
Contributor

jcalfee commented Jul 11, 2016

This could have been two edits that got out of sync due to a fork. We have since improved the TaPOS header so if this were to happen again the older version would have alerted you by rejecting the transaction. We can not fix the post now though. Can you fix it by hand or can you get original version and edit that back into the post?

@abitmore
Copy link
Author

Still buggy. Just posted another reply and same result.

@abitmore
Copy link
Author

To be clear, I replied to a reply of my post and had some quotes (using >) inside.

@Gandalf-the-Grey
Copy link
Contributor

Recently reported: #538

@jcalfee
Copy link
Contributor

jcalfee commented Oct 27, 2016

It is very tricky to get the original data used to create the patch, this succeeds in JavaScript and we don't know there is a problem until we try to view it back from the C++ node applying the patch. If we can't easily find a bug we may have to code around this to detect it.

@jcalfee
Copy link
Contributor

jcalfee commented Oct 27, 2016

Another finding from roadscape:

roadscape [10:34 AM]
https://steemd.com/tx/1cf51df79ebdda9cb5890aa53096f12b58762353 — as far as I can tell, this was the original post. it wasn’t an edit
if that’s the case, for some reason the UI decided to post a patch for a new comment

roadscape [11:27 AM]
https://steemd.com/tx/1cf51df79ebdda9cb5890aa53096f12b58762353
Included in block 6,159,017 at _2016-10-26 03:18:51_
https://steemd.com/life/@logic/re-kairos-re-logic-re-kairos-re-logic-re-cassandracomplex-re-logic-discrimination-objectification-and-exploitation-of-women-is-pervading-we-live-in-patriarchy-the-facts-for-patriarchy-deniers-20161026t031847728z
last_update 2016-10-26 13:22:54
created _2016-10-26 03:18:48_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants