Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show how many flags a post has received #1039

Merged
merged 1 commit into from
Jan 20, 2017

Conversation

TimCliff
Copy link
Contributor

This pull request updates the UI so that flagged posts do not stand out compared to non-flagged posts.

Reasoning:
With the current implementation of "flags" and "downvotes" being combined into the same function, users receiving "downvotes" for non-abusive reasons such as disagreement on rewards has been causing a lot of controversy. Part of the reason is because the interface shows the post as 'flagged' whenever it receives a downvote, which makes the post seem 'bad' compared to non-flagged posts, even if the poster did nothing 'wrong'.

The main argument against this change will be that users can no longer easily identify posts that have been flagged for abusive reasons. While this is true, the current implementation of the flag/downvote at a blockchain level does not provide a good means to do this without also singling out content that has been downvoted for non-abusive reasons. Users that are interested in fighting abuse can use other interfaces (such as steemd or the steemit.chat abuse channel) for this purpose, while regular users will just be presented with the "vote list" (showing the top 20 upvotes/downvotes) and pending post reward.

Ultimately, a more robust long-term solution should be pursued that gives the user the ability to 'flag' or 'downvote' separately, with a way to distinguish between the two.

The pull request makes two changes:

  • Removes the flag counter, so the UI no longer shows a count of how many flags a post has received.
  • Changes the post preview to only show the flag icon when a user hovers over the post. (This is the same behavior as a non-flagged post.)

Here is an example of what flagged posts will look like with the change:
image

Compared to the current UI:
image

The UI will show the flag icon when the user does a mouseover of the post, which is the same behavior as a non-flagged post:
image

If the logged in user has flagged a post, the mouseover will show that post with the red 'flagged' icon, so that the user can still tell if they have flagged the post:
image

Posts and comments that have been flagged to the point of having a negative voting score will still be hidden (the same as before):
image

The downvotes will still be shown in the "vote list", with the same logic as upvotes:
image

Since this is likely going to be a controversial change, I will create a Steemit post describing the PR, to facilitate discussion with the community.

@roadscape
Copy link
Contributor

Makes sense.

@sneak
Copy link
Contributor

sneak commented Jan 31, 2017

Since this is likely going to be a controversial change, I will create a Steemit post describing the PR, to facilitate discussion with the community.

I sort of wish we had discussed this a bit more before merging this in.

@TimCliff
Copy link
Contributor Author

Here is a link to the discussion post.
https://steemit.com/flagging/@timcliff/steemit-com-ui-changes-to-flagging-pull-request-submitted

Surprisingly there was not much objection from the community. There was one person that said they would rather still have it show the flags, because having more information was better than less.

The most common 'complaint' was that people would rather have separate downvote and flag options, but that doesn't really say anything for or against this specific change.

There was also a lot of 'people should only flag for abuse' conversations too, but that also really doesn't impact the change.

Are you not in favor of the change, or just saying you wish there had been more discussion first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants