Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Handle escrow related operations #252

Merged
merged 8 commits into from Apr 27, 2018
Merged

Conversation

gregory-latinier
Copy link

Escrow transfer
Here is an url to test the transfer

/sign/escrow-transfer?from=gregory.latinier&to=ekitcho&agent=fabien&escrow_id=1&sbd_amount=0.001%20SBD&steem_amount=0.000%20STEEM&fee=0.001%20STEEM&ratification_deadline=2018-04-25T19%3A08%3A45&escrow_expiration=2018-04-26T19%3A08%3A45&json_meta={%22terms%22:%22test%22}

The transaction proof : https://steemd.com/tx/3a8db8ebef92fdc2503cdd42fff663a0513cac41

Each field is now validated and parsed:

  • from, to, agent are tested for existing users
  • escrow_id must be an integer
  • sbd_amount, steem_amount, fee are tested as assets (fee can be in STEEM or SBD)
  • ratification_deadline, escrow_expiration are tested as date, they must be in the future and escrow_expiration must be after ratification_deadline
  • json_meta is validated as JSON

@gregory-latinier gregory-latinier added this to the v1.0 milestone Apr 23, 2018
@gregory-latinier gregory-latinier self-assigned this Apr 23, 2018
@bonustrack bonustrack temporarily deployed to sc2-master-pr-252 April 23, 2018 09:26 Inactive
@gregory-latinier gregory-latinier temporarily deployed to sc2-master-pr-252 April 23, 2018 14:02 Inactive
@gregory-latinier gregory-latinier temporarily deployed to sc2-master-pr-252 April 24, 2018 11:43 Inactive
@gregory-latinier gregory-latinier temporarily deployed to sc2-master-pr-252 April 24, 2018 14:41 Inactive
@gregory-latinier
Copy link
Author

Fix #209

@@ -65,6 +65,7 @@
"local-storage": "^1.4.2",
"lodash": "^4.0.0",
"lodash-webpack-plugin": "^0.10.6",
"moment": "^2.22.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lib take 200kb minified now we should remove locales from moment.

@gregory-latinier gregory-latinier temporarily deployed to sc2-master-pr-252 April 26, 2018 12:38 Inactive
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good now

@gregory-latinier gregory-latinier merged commit 0a34389 into master Apr 27, 2018
@gregory-latinier gregory-latinier deleted the 209-escrow-transfer branch May 4, 2018 07:49
lopugit pushed a commit to lopudesigns/weauth that referenced this pull request Oct 7, 2018
* Add escrow transfer validation and parsing query

* Add french translation

* Add approve and dispute

* Add escrow release

* Exclude unused locale in the moment dependencie
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants