This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #209 |
bonustrack
reviewed
Apr 26, 2018
@@ -65,6 +65,7 @@ | |||
"local-storage": "^1.4.2", | |||
"lodash": "^4.0.0", | |||
"lodash-webpack-plugin": "^0.10.6", | |||
"moment": "^2.22.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lib take 200kb minified now we should remove locales from moment.
bonustrack
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good now
lopugit
pushed a commit
to lopudesigns/weauth
that referenced
this pull request
Oct 7, 2018
* Add escrow transfer validation and parsing query * Add french translation * Add approve and dispute * Add escrow release * Exclude unused locale in the moment dependencie
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escrow transfer
Here is an url to test the transfer
/sign/escrow-transfer?from=gregory.latinier&to=ekitcho&agent=fabien&escrow_id=1&sbd_amount=0.001%20SBD&steem_amount=0.000%20STEEM&fee=0.001%20STEEM&ratification_deadline=2018-04-25T19%3A08%3A45&escrow_expiration=2018-04-26T19%3A08%3A45&json_meta={%22terms%22:%22test%22}
The transaction proof : https://steemd.com/tx/3a8db8ebef92fdc2503cdd42fff663a0513cac41
Each field is now validated and parsed: