Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the compression factor 17.2366666 #1

Closed
Hellwz opened this issue Apr 21, 2022 · 2 comments
Closed

About the compression factor 17.2366666 #1

Hellwz opened this issue Apr 21, 2022 · 2 comments
Assignees

Comments

@Hellwz
Copy link

Hellwz commented Apr 21, 2022

Thanks for sharing this code, really a good work.
I'm confused with this factor 17.2366666. From my caculation, the original frame rate is 44100 / 512 = 86.1328125. Then the factor equals 86.1328125 / 5= 17.2265625. I don't know if my calculation method is correct.
Looking forward to your reply.

@stefan-baumann stefan-baumann self-assigned this Apr 21, 2022
@stefan-baumann
Copy link
Owner

Hey, thank you very much for bringing this up, great catch!
Your calculation should be correct and indeed, I cannot find an adequate explanation as to how I ended up with that discrepancy in the default factor. I have been looking into this since yesterday, but I have not gotten further than this comment here, where the comma decimal separator in the 86,183333333 indicates that I copied & pasted this from a calculator (when I type decimal numbers myself, I use a dot as the decimal separator), but I cannot figure out how I arrived at this exact value.
The best explanation I can offer right now is that I must have somehow mistyped when calculating this value. I'll continue to look into my documentation and the original repository (this repository is a subset of a larger repository that contains the code relevant to the paper) and see if I can find out anything else.

Luckily, this discrepancy results in an almost negligible speed difference (less than 0.1%), so this should at least not invalidate any results. But unless I can trace back my steps there and find out how and why I arrived at this specific, seemingly ever-so-slightly incorrect value, this is probably something I should fix.

Thanks again for pointing this out!

@Hellwz
Copy link
Author

Hellwz commented Apr 23, 2022

Got it! Thanks for your quick response and detailed explaination.

@Hellwz Hellwz closed this as completed Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants