Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retroarch-1.6.9 - tad more than a version bump. #85

Closed
jason-oliveira opened this issue Nov 22, 2017 · 2 comments
Closed

retroarch-1.6.9 - tad more than a version bump. #85

jason-oliveira opened this issue Nov 22, 2017 · 2 comments

Comments

@jason-oliveira
Copy link
Contributor

retroarch-1.6.9-build.patch is broken, as orbea rewrote to explicitly die in commit libretro/RetroArch@bf8863d#diff-546edcf091f4cb2bca9608b42cdc1534

from #retroarch on freenode:
‎[16:35] ‎<‎orbea‎>‎ anyways if you want to repatch it, just it from die 1 to die :
‎[16:35] ‎<‎orbea‎>‎ wont exit

seems my patch-fu is weak, otherwise I'd just fix it myself and submit a pull request.
if it helps, the commit hash you'll want to use for 1.6.9 is 6f5cad5f5993e27fc1daa5e5e04f1749164f9a1c

@jason-oliveira
Copy link
Contributor Author

libretro/RetroArch@8ab308d

issue was resolved, patch will likely not be needed in next version of retroarch.

@stefan-gr
Copy link
Owner

Thanks for the report.
It's on gentoo to patch upstream to make it not die on unknown build options. econf drops often used build options on the build system in hopes that something sticks and obeys local customs like EROOT and things. It's pretty useful, if the build system can handle it, but we can't expect upstream to no-op every single unknown option from gentoo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants