You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As suggested in the comments on this PR, it might be useful to create an eclass to share code between ebuilds for different printers. Specifically, I think the following could be shared:
Common dependencies (i.e. cups for net-print ebuilds, sane for media-gfx ebuilds)
Any necessary settings of RESTRICT or other global variables
Inherit linux-info and multilib eclasses to use in a shared pkg_setup phase function
Inherit rpm eclass to use in a shared src_unpack phase function
Low level functions to fix paths, extract PPD, etc.
Possibly shared src_prepare and src_install phase functions using the above low-level functions
I'm willing to help in creating this eclass, and think much of the code could be copy/pasted from my net-print/brother-mfc7460dn-bin ebuild, with appropriate adaptation. However, before actually creating the eclass, I thought it'd be useful to discuss what exactly it should do, to maximize its usefulness. The drivers for different models are similar enough that I envision the possibility of individual ebuilds not having to do much more than inherit a common eclass.
The text was updated successfully, but these errors were encountered:
Sorry, I still haven't looked into this, but I find it a highly interesting direction and a very good approach.
By now this repository contains a lot more scanner and printer then I would have assumed and I'm not able to test the ebuilds on only on a fraction of the devices. So already from the point of maintenance I think it would be good to centralise some of this functionality.
At the moment it's not clear for me which printer drivers are affected by issue #48 . I think these should be the first that profit from the eclass to start working properly.
In the long run all/most of the other existing ebuilds should be updated, but this should happen in an automated way as there are just too many. For me the question is more in the way of "for which subset of printers" should this eclass be useful and how can the script generator/brother-generator.sh be used to regenerate up-to-date ebuilds?
I don't know if this helps but that's currently in my head. :)
As suggested in the comments on this PR, it might be useful to create an eclass to share code between ebuilds for different printers. Specifically, I think the following could be shared:
net-print
ebuilds, sane formedia-gfx
ebuilds)RESTRICT
or other global variableslinux-info
andmultilib
eclasses to use in a sharedpkg_setup
phase functionrpm
eclass to use in a sharedsrc_unpack
phase functionsrc_prepare
andsrc_install
phase functions using the above low-level functionsI'm willing to help in creating this eclass, and think much of the code could be copy/pasted from my
net-print/brother-mfc7460dn-bin
ebuild, with appropriate adaptation. However, before actually creating the eclass, I thought it'd be useful to discuss what exactly it should do, to maximize its usefulness. The drivers for different models are similar enough that I envision the possibility of individual ebuilds not having to do much more than inherit a common eclass.The text was updated successfully, but these errors were encountered: