Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle internationalization #14

Closed
stefan-niedermann opened this issue Oct 6, 2015 · 20 comments
Closed

Handle internationalization #14

stefan-niedermann opened this issue Oct 6, 2015 · 20 comments
Milestone

Comments

@stefan-niedermann
Copy link
Member

Currently translations are only available for English and German. I think we should open a transifex-repo for translations. If anyone speaks another language native, he is welcome to create a pull-request until this is done.

@jancborchardt
Copy link
Member

Yeah, maybe we should even move this repo as »owncloud/notes-android« to the main ownCloud organization on Github to more easily handle translation and contributions. What do you think @stefan-niedermann?

cc @DeepDiver1975 @Henni @Raydiation

@pejakm
Copy link

pejakm commented Oct 22, 2015

There's also https://weblate.org.

@jancborchardt
Copy link
Member

@pejakm we already use Transifex for the whole of ownCloud since the beginning: https://www.transifex.com/projects/p/owncloud/

@pejakm
Copy link

pejakm commented Oct 22, 2015

@jancborchardt I'm aware of this, I'm a member of Serbian translation team for ownCloud. But I missed your comment (sorry!) about moving this project to owncloud organization. In this case it would be akward not to use Transifex.

@jancborchardt
Copy link
Member

@pejakm ah cool, thank you for your translation work then! :)

@pejakm
Copy link

pejakm commented Jan 24, 2016

@stefan-niedermann I forgot to report that few lines in default strings.xml are in German instead of in English. :)

@stefan-niedermann
Copy link
Member Author

ah thanks, will fix this ;) and thanks for your updated translation.

@korelstar
Copy link
Member

Currently, there are still rather few languages available for this app and for many strings the translations are missing. Therefore, Transifex is still an interesting approach in order to improve this situation. It would be cool, if the @nextcloud-bot would take care of this repository, too. In that case, strings are automatically provided to Transifex and translation are automatically imported back to this app.

@stefan-niedermann Even if you don't want to migrate this project to the nextcloud organization, it seems that somebody can configure the @nextcloud-bot to use an external repository (I've seen this somewhere else). However, I don't know who would do that. What do you think?

@jancborchardt
Copy link
Member

cc @MorrisJobke @LukasReschke about the Transifex configuration ^ :)

@MorrisJobke
Copy link
Member

@stefan-niedermann Even if you don't want to migrate this project to the nextcloud organization, it seems that somebody can configure the @nextcloud-bot to use an external repository (I've seen this somewhere else). However, I don't know who would do that. What do you think?

somebody === me ;)

@MorrisJobke
Copy link
Member

@stefan-niedermann Could you add @nextcloud-bot as contributor? Is it then allowed to directly push to master (protected branches need to be disabled or there needs to be an exception for admins and nextcloud-bot added as admin).

@stefan-niedermann
Copy link
Member Author

Well, i would be fine with moving the repository to nextcloud :) I have no idea who is allowed to make this decision @jancborchardt @MorrisJobke.

But before moving i would like to release v0.10.0 which will contain many improvements like inline editing and nextcloud theme colors.

@MorrisJobke
Copy link
Member

Well, i would be fine with moving the repository to nextcloud :) I have no idea who is allowed to make this decision @jancborchardt @MorrisJobke.

Fine by me, but for the transifex integration it doesn't make a difference (beside that I would have the admin rights to set it up from a permission point of view)

@stefan-niedermann
Copy link
Member Author

Could you add @nextcloud-bot as contributor?

Done :)

@nextcloud-bot
Copy link
Member

Done :)

🎉

@MorrisJobke
Copy link
Member

Done :)

now I need to know where you put the original strings and where I should put the translations. Maybe have at our android app and how it is handled there:

@stefan-niedermann
Copy link
Member Author

We use the same schema: res/values and res/values-LANGUAGE_CODE, e. g. the english version is here: https://github.com/stefan-niedermann/nextcloud-notes/blob/master/app/src/main/res/values/strings.xml
Please note that we have besides the strings.xml file a plurals.xml-file (one for each language), e. g. the english version: https://github.com/stefan-niedermann/nextcloud-notes/blob/master/app/src/main/res/values/plurals.xml

@MorrisJobke
Copy link
Member

We use the same schema: res/values and res/values-LANGUAGE_CODE, e. g. the english version is here: https://github.com/stefan-niedermann/nextcloud-notes/blob/master/app/src/main/res/values/strings.xml
Please note that we have besides the strings.xml file a plurals.xml-file (one for each language), e. g. the english version: https://github.com/stefan-niedermann/nextcloud-notes/blob/master/app/src/main/res/values/plurals.xml

Let me see how I can integrate both :) Thanks

@MorrisJobke MorrisJobke mentioned this issue Jan 23, 2017
@MorrisJobke
Copy link
Member

Tested and works - runs now everyday at roughly 2 am (UTC+1) 16796ea

(I copied the de to de_DE too - don't know if this matters, but just in case).

@nextcloud-bot
Copy link
Member

Yep - I will do the daily job 👷 over here in my little server 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants