fixed memory leak #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stefangabos
added a commit
that referenced
this pull request
Jul 9, 2017
|
This is now fixed by adding the missing unbinding of "touchstart" and fixing the multiple-event-bind bug by removing the unnecessary comma. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I wrote in this issue it is better to register an event handler for multiple events separately than registering it in one call because when unbind is called jquery does not find the event handler because of the comma at the end of the event name.
In the fix I register the event handler for the events separately and so the unbinding in the destroy() method is successful and the leak goes away.