Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance todos #143

Closed
stefangweichinger opened this issue Dec 11, 2023 · 6 comments
Closed

maintenance todos #143

stefangweichinger opened this issue Dec 11, 2023 · 6 comments

Comments

@stefangweichinger
Copy link
Owner

Some notes here:
the whole testing and releasing takes even more effort than the actual role ;-)

  • ansible-galaxy seems to want a release-number > 1: that's still not the case in this repo, I assume I have to do that in a next step. Right now I skip the related test in ansible-lint
  • because the release-number wasn't changed, the latest changes didn't yet get released to galaxy
  • the action we use for linting is outdated: has to be replaced: https://github.com/marketplace/actions/run-ansible-lint
  • I added meta/runtime.yml to make ansible-lint happy. The content was taken from an example, it's not correct.
@stefangweichinger
Copy link
Owner Author

stefangweichinger commented Dec 11, 2023

github-action for linting changed in 06924af

Seems to work without problems, great. Will be merged asap.

@stefangweichinger
Copy link
Owner Author

  • semantic versioning: I understand the point of doing that, but I still don't know how to properly use commitizen ... the repository still isn't fully commitizen-friendly. I have to learn this. And then maybe bump the version to 1.0.0 to make ansible-galaxy even happier.

@stefangweichinger
Copy link
Owner Author

0.1.3 released and imported into ansible-galaxy from the shell: the gh-action doesn't work right now

@tigattack
Copy link
Contributor

Hey @stefangweichinger, regarding the Galaxy action which I also saw discussed in #147, perhaps this alternative approach is of interest to you? https://github.com/tigattack/ansible-role-mergerfs/blob/main/.github/workflows/release.yml

@stefangweichinger
Copy link
Owner Author

Hey @stefangweichinger, regarding the Galaxy action which I also saw discussed in #147, perhaps this alternative approach is of interest to you? https://github.com/tigattack/ansible-role-mergerfs/blob/main/.github/workflows/release.yml

Thanks a lot, I'll have a closer look asap.

@stefangweichinger
Copy link
Owner Author

currently the release-step works again (phew!), so I close here just to keep things clean. thanks for the pointer @tigattack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants