-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Perform the install steps" task fails with Jinja2 < 2.11 #83
Comments
Great bug report, thanks. I already considered some pre-test tasks for some things like python-version etc |
I guess ansible has a way to issue a warning in that case, so that seems like a fair idea indeed ! (even though it complicates the logic a bit) But on this specific issue I'm now wondering whether the test I guess it would fail anyway if (and that would entirely get rid of that issue with Jinja's "is true" test) |
to consider, yes. and to test ;-) |
A quick test in a local branch shows that your suggested test fails at the first run:
In the former test that isn't a problem because |
look at #87 : new test statement, new handling of deploying the fact-checking script etc |
For me the latest update still resulted in an error in the named line. I did some experiments and the following line works for me:
|
@dsteinkopf could you show the error you got? My tests in molecule did not fail. What OS, etc? |
@dsteinkopf Just to talk about the same code: I think of merging #87 as all the tests succeeded. Please let me know what failed in your runs. |
@dsteinkopf I merged #87 right now with commit 6b7153f 28 tests successful -> role was released to galaxy right now |
New galaxy version works for me. Thank you very much. |
Great to hear. Thanks for reporting and testing @dsteinkopf |
@theenglishway If you also have no more issues with the current release, I will close here. Thanks. |
Hi !
I'm not sure it's an actual issue but I've just hit an error while trying to run your role in the kind of very simple playbook that you exemplify in the readme :
The error message is :
The test to blame is
(ansible_facts['ansible_local']['rclone']['installed'] is not true) or (ansible_facts['ansible_local']['rclone']['installed_version'] != rclone_version)
in main.yml :ansible-rclone/tasks/main.yml
Line 48 in f281d85
(... which was added in the latest commit)
I installed ansible ages ago via a
pip install --user
, and my installed version is 2.9.9, so I suspected a dependency problem.. and playing around a bit within a virtualenv, I realized the culprit was not ansible but Jinja2.So here's the result of my fiddling around :
(I guess the result will be the same with any version of ansible but I didn't bother to check)
The
true
test was added in Jinja2 version 2.11 indeed : https://jinja.palletsprojects.com/en/2.11.x/changelog/#version-2-11-0Again, I'm not sure how much of an issue it is considering Jinja2 version 2.11 is already more than one year old, and whether you can express that kind of dependency within ansible-galaxy, but I guess one might hit this issue when using old versions of ansible..
Cheers !
The text was updated successfully, but these errors were encountered: