Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Observables subscribion #51

Closed
tarekselem opened this issue Mar 21, 2021 · 0 comments
Closed

Enhance Observables subscribion #51

tarekselem opened this issue Mar 21, 2021 · 0 comments

Comments

@tarekselem
Copy link

Subscribed observables should be unsubscribed after the component being destroyed. I would even prefer moving the observable subscribing to HTML template and subscribing using Async pipe to guarantee unsubscribing will be managed automatically.
@tarekselem tarekselem changed the title Enhance Observables subscribing Enhance Observables subscribion Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanoslig @tarekselem