Add --type option and check to controller and route blueprints #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use `--type=foo` instead of `type:foo` in route and resource blueprints.
|
👍 |
stefanpenner
added a commit
that referenced
this pull request
Jul 26, 2014
Add --type option and check to controller and route blueprints
|
@jgwhite Should it really warn if you don't specify the controller? To me that seems a little unnecessary. I think it should just default to basic and not warn about it. Thoughts? /cc @stefanpenner |
|
@jakecraige I went back and forth on this a lot and in the end I think @jackmatt2’s suggestion is the best compromise between avoiding potential pitfalls for newcomers and keeping ember-cli direct and fuss-free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1391