Add --silent option for a quieter UI #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // first, run `npm install -g ember-cli` | ||
| var npm = this.npm; | ||
| var loadNPM = Promise.denodeify(npm.load); | ||
|
|
||
| var stopProgress = (function() { | ||
| this.ui.pleasantProgress.stop(); | ||
| this.ui.stopPleasantProgress(); |
There was a problem hiding this comment.
we can likely drop the work pleasant
There was a problem hiding this comment.
good call, could never spell that right anyway
|
👍 left one tiny OCD comment. |
Passing the --silent command to any command will supress all output from the UI expect errors. Introduces write levels to the UI object. Changes pleasant-progress commands to pass through the UI object first. The UI simply delegates the commands to it’s `PleasantProgress` object.
|
Thanks, updated and squashed. |
|
can you add docs in another PR to the site ? |
stefanpenner
added a commit
that referenced
this pull request
Nov 27, 2014
Add --silent option for a quieter UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2423. Passing
--silentto any command will set the UI will only write errors. This allows XML output fromember testto be captured in a file without any additional text (printed ember version, pleasent progress, etc.)To achieve this, I introduced the concept of a write level / log level to the UI object.
UI.writeandUI.writeLinenow accept a second argument that is the write level. If the write level set for the UI is higher the write level passed toUI.write, nothing will be printed. By default, the write level for aUIobject and forUI.writeandUI.writeLineis'INFO'. The write levels, in order, are:'DEBUG','INFO','WARNING','ERROR'.This is my first time working in node / on ember-cli—if the implementation is off let me know how I can change it. I would be happy to add tests if all looks well.