Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Leek #448

Merged
merged 8 commits into from
Apr 26, 2014
Merged

Integrate Leek #448

merged 8 commits into from
Apr 26, 2014

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Apr 26, 2014

@twokul twokul mentioned this pull request Apr 26, 2014
4 tasks
@@ -47,7 +49,15 @@ function Command(options) {
throw new Error('Command "' + this.name + '" has no run() defined.');
}

this.run = options.run;
this.run = function(ui, environment) {
if (environment && environment.cliArgs && self.leek) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when are we missing leak?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant check, will fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would only be concerned that it masks actual errors.

@stefanpenner stefanpenner added this to the v0.0.24 milestone Apr 26, 2014
@stefanpenner stefanpenner changed the title WIP Integrate Leek Apr 26, 2014
@stefanpenner
Copy link
Contributor

thanks bro!!

stefanpenner added a commit that referenced this pull request Apr 26, 2014
@stefanpenner stefanpenner merged commit 1455247 into ember-cli:master Apr 26, 2014
lukemelia added a commit that referenced this pull request Apr 26, 2014
@twokul twokul deleted the analytics branch April 26, 2014 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants