Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose server, server baseURL stuff, project.require() #683

Merged
merged 1 commit into from
May 10, 2014

Conversation

MajorBreakfast
Copy link
Contributor

Info about changes in changelog.

@stefanpenner @rjackson Please review this. I'd like to merge it in the next view hours. Rebasing is a pain ;)

This was referenced May 10, 2014
'use strict';

module.exports = function(baseURL) {
if (!baseURL) { return; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function should be very easy to test, as it has some algorithmic complexity please add some tests for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created one.

@stefanpenner
Copy link
Contributor

i made some comments, but think this is a great addition.

MajorBreakfast added a commit that referenced this pull request May 10, 2014
Expose server, server baseURL stuff, project.require()
@MajorBreakfast MajorBreakfast merged commit de2671d into master May 10, 2014
@MajorBreakfast MajorBreakfast deleted the server branch May 10, 2014 18:02
@WMeldon
Copy link
Contributor

WMeldon commented May 12, 2014

Just tried this out and I noticed that express-namespace and body-parser were missing. I added them back easily enough, but I was wondering if they should be included by default.

Thoughts?

@MajorBreakfast
Copy link
Contributor Author

The body parser was previously part of express. If you tend to include it anyway we might as well ship with it. Mind providing a PR?
But maybe we should just ship with the body parser and mention express namespace in the docs. Would that be alright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants