Missing newline at end of es6-promise.js

[geroyche]

We're using concatenation tools to merge our bower dependencies. The missing newline at the end of es6-promise.js breaks this process (the subsequent file starts with a comment indicator /*! which gets concatenated to the comment //# sourceMappingURL=es6-promise.map ), making the next line invalid

[stefanpenner]

@geroyche which concatenator?

[geroyche]

Grunt contrib concat.
Not sure it's really relevant though.
Adding an enter character at the end of the file does fix the issue.

[stefanpenner]

Not sure it's really relevant though.

I was curious, as most of the concat scripts I have worked on explicitly add a newline do to this ambiguity.

[geroyche]

Ah, ok :)

[stefanpenner]

@geroyche I believe this to be a bug in grunt contrib concat, but I can also make this code more resilient. How about a trade, open an issue there so it is on their radar and I will make our concatenator more defensive.

[stefanpenner]

ef4/fast-sourcemap-concat#27