Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract away the concept of a clientId in the Client Ratelimiter #54

Closed
ghstahl opened this issue Nov 16, 2018 · 1 comment
Closed

Comments

@ghstahl
Copy link

ghstahl commented Nov 16, 2018

A client_id can come in many forms. Your implementation is one of those forms.
Others come in the form of an OAuth2 POST where client_id/client_secret is in the form of an application/x-www-form-urlencoded value or in the header as basic auth.

In others the could show up somewhere in an application/json post.

The client filter is nice but I need to change where that client_id is coming from.

@cristipufu
Copy link
Collaborator

Should be fixed with #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants