Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing schedule on Kelvin web interface causes "enableWhenLightsAppear" boolean to be reset to false #36

Closed
Abushawish opened this issue Jun 11, 2018 · 1 comment · Fixed by #76
Assignees
Labels

Comments

@Abushawish
Copy link

I know the web interface is in beta, but wanted to give feedback.

Version:
Kelvin v1.1.6 running on a Raspberry Pi 3

Prerequisites:

  1. Web interface in Kelvin should be enabled
  2. "enableWhenLightsAppear" attribute in config.json should be set to true

To recreate:

  1. Open web interface of Kelvin and head to schedules tab
  2. Change/add something (example: add entry for the morning at 2AM with 2400 temperature and 60% brightness).
  3. Hit "Save Schedules" at the bottom
  4. Head to "/home/pi/kelvin" and open config.json
  5. Notice the "enableWhenLightsAppear" has been reset to false even though it was true originally

Please let me know if I am doing something wrong or more info is needed :).

@stefanwichmann stefanwichmann self-assigned this Jun 29, 2018
@stefanwichmann
Copy link
Owner

Hi Moe,

thanks for the report! Even if the web interface is in beta any feedback is valuable.

This is definitely a bug. The "enableWhenLightsAppear" option was added to Kelvin after I last updated the web interface code. So every time the browser send a new config, the default for this option is assumed. And the default is false...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants