Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal-redis leaks memory? #79

Closed
saturn-network opened this issue Feb 19, 2019 · 7 comments
Closed

crystal-redis leaks memory? #79

saturn-network opened this issue Feb 19, 2019 · 7 comments

Comments

@saturn-network
Copy link

Perhaps because of ysbaddaden/pool#2

Symptoms: when using crystal-redis inside amber framework with pooledconnection to cache responses, heroku dynos run out of memory (I presume due to request buffer filling up) and no requests end up getting served, the get stuck on redis.get.

Does anybody have a success story using crystal-redis with amber framework or in production for web services in general?

@stefanwille
Copy link
Owner

Do you have repo that I can use to reproduce the issue?

@kostya
Copy link
Collaborator

kostya commented Feb 19, 2019

there is no failed instances in pool, all connection reestablished when needed

@saturn-network
Copy link
Author

@stefanwille unffortunately not at the moment. I shall do my best to come up with a minimal reproducible example and push that as a repo.

@kostya that may well be. Still, in practice what I have observed is that the instance grew its mem usage and died under load, and this only happens when we're using redis caching.

@stefanwille
Copy link
Owner

@saturn-network that minimal reproducible example would be very helpful

@saturn-network
Copy link
Author

I can imagine :) Do you want to close the issue for now and have me reopen it when it's done, or do you want to keep it open?

@stefanwille
Copy link
Owner

Please leave this issue open for now.

@saturn-network
Copy link
Author

Will open a new issue to track this with the writeup guiding through how the project is initialized, where redis comes into play, and we can discuss how to properly stress test the server and detect where the issues might be happening.

Perhaps the issue is with a specific amber version, or wrong usage of the language, or poorly configured GC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants