Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate ids error #21

Closed
rickb777 opened this issue Aug 24, 2018 · 4 comments
Closed

duplicate ids error #21

rickb777 opened this issue Aug 24, 2018 · 4 comments

Comments

@rickb777
Copy link

Your theme generates badly-formed HTML with several duplicate ids. These are not allowed by W3C specs.

For example in index.html
id="menu-icon-wrapper"
id="menu-icon-trigger"
@rickb777
Copy link
Author

It seems these can simply be deleted from the source templates without affecting the javascript code.

@lucperkins
Copy link
Collaborator

@rickb777 This theme is just a Hugo wrapper around someone else's logic. Is there a visual issue here or just a spec issue?

@StefMa
Copy link
Owner

StefMa commented Mar 26, 2019

Hi @rickb777
can you please give us an update here and answer the question from @lucperkins ? :)

@StefMa
Copy link
Owner

StefMa commented Jun 18, 2019

Closed due inactivity...

@StefMa StefMa closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rickb777 @lucperkins @StefMa