Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file diffing issue #232

Closed
wants to merge 2 commits into from
Closed

Conversation

jasonwaters
Copy link

I found that there was a significant amount of churn during sync. for example, here is some data representing what happened during a routine sync:

remote entities		171,682


to be added			170,646
to be deleted		        82973
to be kept			1036

notice that 82,973 local entities are deleted and 170k added. this seemed fishy to me, so I investigated.

It turns out that assets are compared to see if they are roughly equal. Part of that is to check if the modified date is within close range. It was using 10ms as wiggle room for the range. But I saw elsewhere 1000ms is used. I bumped the 10 to 1000 in the equal method of the asset class and it fixed the comparison problem i was having. These are the results afterwards:

remote entities		171,682


to be added			87,674
to be deleted		1
to be kept			84008

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

This issue should be resolved with version v1.1.1-beta.1, please confirm.

@github-actions github-actions bot added the status(previewed) This issue or pull request should be fixed in a released beta version label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status(previewed) This issue or pull request should be fixed in a released beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant