Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[5] Protocol 12: path_payment type field change for fill tracker #295

Open
nikhilsaraf opened this issue Sep 20, 2019 · 0 comments
Open

[5] Protocol 12: path_payment type field change for fill tracker #295

nikhilsaraf opened this issue Sep 20, 2019 · 0 comments
Assignees
@nikhilsaraf
Labels
bug Something isn't working
Milestone
later

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Sep 20, 2019 •
edited
Loading

Desired Behavior

I want to continue having support for fill tracking with the new protocol v12 upgrade

Impact

The desired behavior will allow me to continue operating Kelp through the new protocol v12 upgrade.

Feature Suggestion

the operations endpoint has a type and type_i field. Kelp uses only type in identifying the type of operation for the fill tracker, specifically trade, or path_payment.

In protocol 12 we will have types path_payment_strict_send and path_payment_strict_receive with possible backward compatibility for path_payment type.

Kelp would not recognize this new type so that needs to be fixed.

References

  • See previous change where support for the path_payment type was added.
  • CAP-0024 describing this change in stellar-core
@nikhilsaraf nikhilsaraf added the feature request New feature or request label Sep 20, 2019
@nikhilsaraf nikhilsaraf added this to Triage in Kelp via automation Sep 20, 2019
@nikhilsaraf nikhilsaraf added this to the v1.7.3 milestone Sep 20, 2019
@nikhilsaraf nikhilsaraf added bug Something isn't working and removed feature request New feature or request labels Oct 29, 2019
@nikhilsaraf nikhilsaraf changed the title Protocol 12: path_payment type field change for fill tracker [1] Protocol 12: path_payment type field change for fill tracker Oct 29, 2019
@nikhilsaraf nikhilsaraf modified the milestones: v1.7.4, v1.8.0, v1.8.1, v1.8.x Feb 10, 2020
@nikhilsaraf nikhilsaraf removed this from Triage in Kelp Aug 31, 2020
@nikhilsaraf nikhilsaraf changed the title [1] Protocol 12: path_payment type field change for fill tracker [5p] Protocol 12: path_payment type field change for fill tracker Aug 31, 2020
@nikhilsaraf nikhilsaraf changed the title [5p] Protocol 12: path_payment type field change for fill tracker [3p] Protocol 12: path_payment type field change for fill tracker Aug 31, 2020
@nikhilsaraf nikhilsaraf changed the title [3p] Protocol 12: path_payment type field change for fill tracker [5p] Protocol 12: path_payment type field change for fill tracker Aug 31, 2020
@nikhilsaraf nikhilsaraf changed the title [5p] Protocol 12: path_payment type field change for fill tracker [5] Protocol 12: path_payment type field change for fill tracker Sep 20, 2020
@nikhilsaraf nikhilsaraf modified the milestones: v1.8.x, later Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nikhilsaraf nikhilsaraf

Labels
bug Something isn't working
Projects
None yet
Milestone
later
Development

No branches or pull requests
3 participants
@nikhilsaraf @debnil @shanzzam