Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[1] Kelp GUI: we need an explicit "quit" button inside the Kelp GUI window #357

Closed
nikhilsaraf opened this issue Feb 5, 2020 · 0 comments
Assignees
Labels
feature request New feature or request GUI issues related to the Kelp GUI release-blocker this issue is blocking a release
Projects
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

Desired Behavior

It needs to be more intuitive about how to quit kelp. We need some way of quitting kelp from within the app window.

Impact

Users will know how to close the app. This will also have the effect of shutting down all the bots before closing.

Feature Suggestion

Currently, users do not know to quit the app by clicking on the status bar icon.

Crossing out the window is disabled because electron does not give us a onClose() hook last I checked.

We can achieve the desired behavior by:

  1. including a button inside the Kelp GUI (not via react but via the electron framework) which invokes the quit() method that we already have.
  2. this will shut down all bots before quitting.
  3. provide UI feedback that bots are being shut down to provide UI feedback on the user's click and to report progress.
@nikhilsaraf nikhilsaraf added feature request New feature or request GUI issues related to the Kelp GUI release-blocker this issue is blocking a release labels Feb 5, 2020
@nikhilsaraf nikhilsaraf added this to the v1.8.0 milestone Feb 5, 2020
@nikhilsaraf nikhilsaraf self-assigned this Feb 5, 2020
@nikhilsaraf nikhilsaraf added this to Triage in Kelp via automation Feb 5, 2020
@nikhilsaraf nikhilsaraf changed the title Kelp GUI: we need an explicit "quit" button inside the Kelp GUI window [1] Kelp GUI: we need an explicit "quit" button inside the Kelp GUI window Feb 5, 2020
@nikhilsaraf nikhilsaraf modified the milestones: v1.8.0, v1.8.1, v1.8.x Feb 10, 2020
Kelp automation moved this from Triage to Done Feb 26, 2020
@nikhilsaraf nikhilsaraf modified the milestones: v1.8.x, v1.9.0 May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request New feature or request GUI issues related to the Kelp GUI release-blocker this issue is blocking a release
Projects
Kelp
  
Done
Development

No branches or pull requests

1 participant