Handle case where account hasn't been created

[msfeldstein]

It's possible to create a deposit on an account that hasn't been created yet. In that case, we depend on the anchor to create the account, which we need to wait for, then add the trustline, then complete the rest of the deposit.

@accordeiro explains here: https://github.com/stellar/sep6-demo-client/pull/93

The deposit flow does not require a Stellar account to be created upfront, i.e. you can provide the public key of an account that does not exist until that moment (similarly to what we do with Friendbot). In this case, it'll be the anchor's responsibility to create that Stellar account and provide it with the minimum recommended funding (2.01XLM).

So I think the correct flow would be:

    Check /info
    Get /deposit (using the key provided by the config, regardless of it being an existing account)
    Interactive deposit flow
    Start polling transactions
    If we get a pending_trust as a response, then we actually perform the trustline creation

Does that make sense? The code is a bit messy, but I think this describes the exact moment in which we should establish a trustline: 

[accordeiro]

Thanks @msfeldstein!

I wonder if we should increase the priority of this change, since on testnet it's easy to get some initial funding for an account (through Friendbot + lab) but on mainnet we'll probably see more cases where wallets expect the account creation / funding to be performed by that anchor – as otherwise they'd need to buy real XLM through some other means.

Considering that, we probably need to ensure new anchors are properly implementing this account creation and initial funding flow. Does that make sense? @tomerweller @tomquisel I'd love to hear your thoughts as well.

[msfeldstein]

I think this is probably the next highest priority thing

…

On Thu, Sep 26, 2019 at 8:42 AM Alex Cordeiro ***@***.***> wrote: Thanks @msfeldstein <https://github.com/msfeldstein>! I wonder if we should increase the priority of this change, since on testnet it's easy to get some initial funding for an account (through Friendbot + lab) but on mainnet we'll probably see more cases where wallets expect the account creation / funding to be performed by that anchor – as otherwise they'd need to buy real XLM through some other means. Considering that, we probably need to ensure new anchors are properly implementing this account creation and initial funding flow. Does that make sense? @tomerweller <https://github.com/tomerweller> @tomquisel <https://github.com/tomquisel> would love to hear your thoughts as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/stellar/sep6-demo-client/issues/95?email_source=notifications&email_token=AABHK352JZI4WSCN6KGKFIDQLS34NA5CNFSM4IRK7KEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7VTE3A#issuecomment-535507564>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABHK362XVGAZV3YRIQI5G3QLS34NANCNFSM4IRK7KEA> .

[tomquisel]

I agree, this is high priority. It shouldn't be much of an issue for our mobile wallet since it'll pre-fund accounts, but it'll be a real stumbling block with any other wallet.