Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

(0.5) remove minOrderSizeBase from UUID in sellTwapLevelProvider.go #482

Closed
nikhilsaraf opened this issue Aug 19, 2020 · 0 comments
Closed

(0.5) remove minOrderSizeBase from UUID in sellTwapLevelProvider.go #482

nikhilsaraf opened this issue Aug 19, 2020 · 0 comments
Assignees
@nikhilsaraf
Labels
bug Something isn't working
Projects
Kelp
Milestone
v1.10.0

Comments

@nikhilsaraf
Copy link
Contributor

this will ensure more consistent UUIDs for buckets. The bucket's unique ID is independent of the minOrderSizeBase configuration since two bots with different minOrder size configs that overlap on the same time slot with all other params as the same should logically use the same bucket UUID.
@nikhilsaraf nikhilsaraf added the bug Something isn't working label Aug 19, 2020
@nikhilsaraf nikhilsaraf added this to the v1.10.0 milestone Aug 19, 2020
@nikhilsaraf nikhilsaraf self-assigned this Aug 19, 2020
@nikhilsaraf nikhilsaraf added this to Triage in Kelp via automation Aug 19, 2020
Kelp automation moved this from Triage to Done Aug 19, 2020
@nikhilsaraf nikhilsaraf changed the title remove minOrderSizeBase from UUID in sellTwapLevelProvider.go [0.5] remove minOrderSizeBase from UUID in sellTwapLevelProvider.go Aug 19, 2020
@nikhilsaraf nikhilsaraf changed the title [0.5] remove minOrderSizeBase from UUID in sellTwapLevelProvider.go [0.5] (0.5) remove minOrderSizeBase from UUID in sellTwapLevelProvider.go Aug 31, 2020
@nikhilsaraf nikhilsaraf changed the title [0.5] (0.5) remove minOrderSizeBase from UUID in sellTwapLevelProvider.go (0.5) remove minOrderSizeBase from UUID in sellTwapLevelProvider.go Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nikhilsaraf nikhilsaraf

Labels
bug Something isn't working
Projects
Kelp
  
Done
Milestone
v1.10.0
Development

No branches or pull requests
1 participant
@nikhilsaraf