This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
Stellar -> Ethereum withdrawal endpoint #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
force-pushed
the
eth-withdrawal
branch
2 times, most recently
from
c6fd5dc
to
bada114
Compare
tamirms
changed the title
tamirms
changed the title
bartekn
approved these changes
Jul 8, 2022
Comment on lines
+70
to
+72
| if latest.Number <= s.EthereumFinalityBuffer { | ||
| return EthereumWithdrawalDetails{}, EthereumNodeBehind | ||
| } |
There was a problem hiding this comment.
Can you explain this condition? Isn't it almost always going to be false?
There was a problem hiding this comment.
yeah, it should always be false. the only situation where it will be true is if the ethereum node is somehow starting from scratch and catching up from the first block in history
There was a problem hiding this comment.
I added that condition to prevent an integer underflow when evaluating latest.Number-s.EthereumFinalityBuffer in the lines of code below
Co-authored-by: Bartek Nowotarski <bartek@nowotarski.info>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73 , #75