This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Update recovery data after changing password #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var keychainData = JSON.parse(wallet.getKeychainData()); | ||
| return wallet.enableRecovery({ | ||
| recoveryCode: $stateParams.recoveryCode, | ||
| secretKey: keychainData.signingKeys.secretKey |
There was a problem hiding this comment.
Since this function is getting a little hard to read it might be a good time to organize some of this logic into helper methods.
There was a problem hiding this comment.
I would try to avoid the extra then "pass through" by isolating the paths that need access to wallet into one block.
There was a problem hiding this comment.
You're right. I reorganized this code to be easier to read.
|
👍 |
bartekn
added a commit
that referenced
this pull request
Dec 10, 2014
Update recovery data after changing password
This was referenced Jan 21, 2015
bartekn
added a commit
that referenced
this pull request
Jan 22, 2015
bartekn
added a commit
that referenced
this pull request
Jan 27, 2015
Display message to users affected by change password bug #1113
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes stellar/ix#421.