This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Remove totpKey during successful login after TOTP grace period (fix #62) #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -262,11 +262,26 @@ walletV2.clearTotpRemovalRequestIfPossible = function(wallet) { | |||
| if(!wallet.totpDisabledAt) { | |||
| return Promise.resolve(); | |||
| } else { | |||
| // set the totpDisabledAt to null | |||
| var now = Math.floor((new Date()).getTime() / 1000); | |||
| var disabledAt = Math.floor(wallet.totpDisabledAt.getTime() / 1000); | |||
There was a problem hiding this comment.
Why aren't you just directly comparing dates?
if (wallet.totpDisabledAt > new Date())
...
There was a problem hiding this comment.
I copied it from here. I was thinking about the same thing but I thought there's something important behind rounding it to seconds. Can change this.
|
@bartekn I've updated the tests. thoughts? |
|
|
||
| it("resets the totpKey and totpDisabled after the grace period has elapsed", function() { | ||
| var username = "mfa-disabled@stellar.org"; | ||
| return this.submit({username:username, walletId:new Buffer(username).toString("base64")}) |
There was a problem hiding this comment.
The only thing I'd change is adding:
.expect(200)here and in the second test. The rest is OK! 👍
nullstyle
added a commit
that referenced
this pull request
Jan 12, 2015
Remove totpKey during successful login after TOTP grace period (fix #62)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were cancelling TOTP grace period after successful login (by setting
totpDisabledAttonull) but we haven't tested logging in after TOTP grace period. In this case we should removetotpKeyfrom a wallet.