Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EdgeSplitter: introduce a switch for keeping the reduced graph connected #285

Closed
6 tasks done
youph opened this issue Nov 9, 2018 · 1 comment
Closed
6 tasks done

EdgeSplitter: introduce a switch for keeping the reduced graph connected #285

youph opened this issue Nov 9, 2018 · 1 comment
Assignees
@PantelisElinas
Labels
enhancement New feature or request
Milestone
v0.3 Sprint 4

Comments

@youph
Copy link
Contributor

youph commented Nov 9, 2018 •
edited by PantelisElinas

Description

Currently EdgeSplitter ensures that sampled positive edges are not from the graph's spanning tree, which is done to ensure that removing these edges does not increase the number of connected components in the reduced graph.

We should allow users to switch this behaviour on or off with a switch (e.g., keep_connected) passed to the train_test_split method.

Done Checklist (Development)

  • Produced code for required functionality
  • Branch and Pull Request build on CI
  • Branch and Pull Request pass unit tests on CI
  • Peer Code Review Performed
  • Code well commented
  • Documentation in repo
@youph youph added enhancement New feature or request ml labels Nov 9, 2018
@youph
Copy link
Contributor Author

youph commented Nov 9, 2018

This is also needed to simplify @lichaoir 's comparison with platform.

@PantelisElinas PantelisElinas added this to the v0.3 Sprint 4 milestone Nov 18, 2018
@PantelisElinas PantelisElinas mentioned this issue Nov 20, 2018
Merged
@sktzwhj sktzwhj closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PantelisElinas PantelisElinas

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3 Sprint 4
Development

No branches or pull requests
3 participants
@sktzwhj @youph @PantelisElinas