Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'activations' to GraphSAGE and HinSAGE classes #381

Closed
6 of 10 tasks
adocherty opened this issue May 2, 2019 · 0 comments
Closed
6 of 10 tasks

Add 'activations' to GraphSAGE and HinSAGE classes #381

adocherty opened this issue May 2, 2019 · 0 comments
Assignees

Comments

@adocherty
Copy link
Contributor

adocherty commented May 2, 2019

Description

Currently the GCN and GAT layers allow specifying the activations at each layer of the network. GraphSAGE and HinSAGE do not, but rather hard code the activations to "relu" for all layers except the final one which is "linear".

Let's change the GraphSAGE class to accept an "activations" argument to specify the activations at all levels. The default behaviour should match the current implementation.

User Story

As a: user of stellargraph library
I want: have similar configuration options for each graph ML class
so that: I can switch between models easily

Done Checklist (Development)

  • Assumptions of the user story met
  • Produced code for required functionality
  • Branch and Pull Request build on CI
  • Branch and Pull Request pass unit tests on CI
  • Version number reflects new status
  • Peer Code Review Performed
  • Code well commented
  • Documentation in repo
  • CHANGELOG.md updated
  • Team demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants