/
terraform-rules.yml
701 lines (638 loc) · 16.7 KB
/
terraform-rules.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
---
version: 1
description: Terraform rules for demo
type: Terraform
files:
- "*"
rules:
- id: SG_WORLD_INGRESS
resource: aws_security_group
message: Security group should not allow ingress from 0.0.0.0/0 or ::/0
severity: WARNING
assertions:
- not:
- or:
- key: "ingress[].cidr_blocks[]"
op: contains
value: "0.0.0.0/0"
- key: "ingress[].cidr_blocks[]"
op: contains
value: "::/0"
tags:
- sg
- id: SG_WORLD_EGRESS
resource: aws_security_group
message: Security group should not allow egress to 0.0.0.0/0 or ::/0
severity: WARNING
assertions:
- not:
- or:
- key: "egress[].cidr_blocks[]"
op: contains
value: "0.0.0.0/0"
- key: "egress[].cidr_blocks[]"
op: contains
value: "::/0"
tags:
- sg
- id: SG_SSH_WORLD_INGRESS
resource: aws_security_group
message: Security group should not allow ingress from 0.0.0.0/0 or ::/0
severity: FAILURE
assertions:
- not:
- or:
- key: "ingress[?(from_port==`22`)].cidr_blocks[]"
op: contains
value: "0.0.0.0/0"
- key: "ingress[?(from_port==`22`)].cidr_blocks[]"
op: contains
value: "::/0"
tags:
- sg
- id: SG_RD_WORLD_INGRESS
resource: aws_security_group
message: Security group should not allow ingress from 0.0.0.0/0 or ::/0
severity: FAILURE
assertions:
- not:
- or:
- key: "ingress[?(from_port==`3389`)].cidr_blocks[]"
op: contains
value: "0.0.0.0/0"
- key: "ingress[?(from_port==`3389`)].cidr_blocks[]"
op: contains
value: "::/0"
tags:
- sg
- id: SG_NON_32_INGRESS
resource: aws_security_group
message: Security group should not allow ingress from CIDR block that does not end in /32
severity: WARNING
assertions:
- key: "ingress[].cidr_blocks[] | [0]"
op: regex
value: ".*/32$"
tags:
- sg
- id: SG_INGRESS_PORT_RANGE
resource: aws_security_group
message: Security group ingress should specify single port instead of range
severity: WARNING
assertions:
- key: "ingress[?(from_port!=to_port)]"
op: empty
tags:
- sg
- id: SG_EGRESS_PORT_RANGE
resource: aws_security_group
message: Security group egress should specify single port instead of range
severity: WARNING
assertions:
- key: "egress[?(from_port!=to_port)]"
op: empty
tags:
- sg
- id: SG_MISSING_EGRESS
resource: aws_security_group
message: Security group should specify egress rules
severity: WARNING
assertions:
- key: "egress"
op: present
tags:
- sg
- id: CLOUDFRONT_LOGGING
message: CloudFront Distribution must configure logging
resource: s3_distribution
severity: FAILURE
assertions:
- key: logging_config
op: present
tags:
- cf
- id: ROLE_POLICY_NOT_ACTION
message: Should not use NotAction in IAM policy
resource: aws_iam_role_policy
severity: WARNING
assertions:
- key: policy.Statement[].NotAction
op: absent
tags:
- iam
- policy
- id: ROLE_POLICY_NOT_RESOURCE
message: Should not use NotResource in IAM policy
resource: aws_iam_role_policy
severity: WARNING
assertions:
- key: policy.Statement[].NotResource
op: absent
tags:
- iam
- policy
- id: ROLE_POLICY_WILDCARD_ACTION
message: Should not use wildcard action in IAM policy
resource: aws_iam_role_policy
severity: FAILURE
assertions:
- not:
- key: policy.Statement[].Action
op: contains
value: "*"
tags:
- iam
- policy
- id: ROLE_POLICY_WILDCARD_RESOURCE
message: Should not use wildcard resource in IAM policy
resource: aws_iam_role_policy
severity: WARNING
assertions:
- not:
- key: policy.Statement[].Resource
op: contains
value: "*"
tags:
- iam
- policy
- id: POLICY_NOT_ACTION
message: Should not use NotAction in IAM policy
resource: aws_iam_policy
severity: WARNING
assertions:
- key: assume_role_policy.Statement[].NotAction
op: absent
tags:
- iam
- policy
- id: POLICY_NOT_RESOURCE
message: Should not use NotResource in IAM policy
resource: aws_iam_policy
severity: WARNING
assertions:
- key: assume_role_policy.Statement[].NotResource
op: absent
tags:
- iam
- policy
- id: POLICY_WILDCARD_ACTION
message: Should not use wildcard action in IAM policy
resource: aws_iam_policy
severity: FAILURE
assertions:
- not:
- key: assume_role_policy.Statement[].Action
op: contains
value: "*"
tags:
- iam
- policy
- id: ROLE_NOT_ACTION
message: Should not use NotAction in IAM role
resource: aws_iam_role
severity: WARNING
assertions:
- key: assume_role_policy.Statement[].NotAction
op: absent
tags:
- iam
- role
- id: ROLE_NOT_RESOURCE
message: Should not use NotResource in IAM role
resource: aws_iam_role
severity: WARNING
assertions:
- key: assume_role_policy.Statement[].NotResource
op: absent
tags:
- iam
- role
- id: ROLE_WILDCARD_ACTION
message: Should not use wildcard action in IAM role
resource: aws_iam_role
severity: FAILURE
assertions:
- not:
- key: assume_role_policy.Statement[].Action
op: contains
value: "*"
tags:
- iam
- role
- id: ROLE_WILDCARD_RESOURCE
message: Should not use wildcard action in IAM role
resource: aws_iam_role
severity: FAILURE
assertions:
- not:
- key: assume_role_policy.Statement[].Resource
op: contains
value: "*"
tags:
- iam
- role
- id: ELB_ACCESS_LOGGING
message: ELB should enable access logging
resource: aws_elb
severity: WARNING
assertions:
- key: access_logs
op: present
tags:
- elb
- id: S3_BUCKET_ACL
message: S3 Bucket should not be public
resource: aws_s3_bucket
severity: FAILURE
assertions:
- key: acl
op: not-in
value: public-read,public-read-write
- id: S3_BUCKET_ENCRYPTION
message: S3 Bucket should be encrypted
resource: aws_s3_bucket
severity: FAILURE
conditions:
- key: "tags[].classification[] | [0]"
op: in
value: PII,HIPAA
assertions:
- key: server_side_encryption_configuration
op: present
- id: S3_NOT_ACTION
message: Should not use NotAction in S3 bucket policy
resource: aws_s3_bucket_policy
severity: WARNING
assertions:
- key: policy.Statement[].NotAction
op: absent
tags:
- s3
- id: S3_NOT_PRINCIPAL
message: Should not use NotPrincipal in S3 bucket policy
resource: aws_s3_bucket_policy
severity: WARNING
assertions:
- key: policy.Statement[].NotPrincipal
op: absent
tags:
- s3
- id: S3_BUCKET_POLICY_WILDCARD_PRINCIPAL
message: Should not use wildcard principal in S3 bucket policy
resource: aws_s3_bucket_policy
severity: WARNING
assertions:
- not:
- key: policy.Statement[].Principal
op: contains
value: "*"
tags:
- s3
- id: S3_BUCKET_POLICY_WILDCARD_ACTION
message: Should not use wildcard Principal in S3 bucket policy
resource: aws_s3_bucket_policy
severity: WARNING
assertions:
- not:
- key: policy.Statement[].Action
op: contains
value: "*"
tags:
- s3
- id: SNS_TOPIC_POLICY_WILDCARD_PRINCIPAL
message: Should not use wildcard Principal in SNS topic policy
resource: aws_sns_topic_policy
severity: WARNING
assertions:
- not:
- key: policy.Statement[].Principal
op: contains
value: "*"
tags:
- sns
- id: SNS_TOPIC_POLICY_NOT_ACTION
message: Should not use NotAction in SNS topic policy
resource: aws_sns_topic_policy
severity: WARNING
assertions:
- key: policy.Statement[].NotAction
op: absent
tags:
- sns
- id: SNS_TOPIC_POLICY_NOT_PRINCIPAL
message: Should not use NotPrincipal in SNS topic policy
resource: aws_sns_topic_policy
severity: WARNING
assertions:
- key: policy.Statement[].NotPrincipal
op: absent
tags:
- sns
- id: SQS_QUEUE_POLICY_WILDCARD_PRINCIPAL
message: Should not use wildcard principal in SQS queue policy
resource: aws_sqs_queue_policy
severity: WARNING
assertions:
- not:
- key: policy.Statement[].Principal
op: contains
value: "*"
tags:
- sqs
- id: SQS_QUEUE_POLICY_WILDCARD_ACTION
message: Should not use wildcard action in SQS queue policy
resource: aws_sqs_queue_policy
severity: WARNING
assertions:
- not:
- key: policy.Statement[].Action
op: contains
value: "*"
tags:
- sqs
- id: SQS_QUEUE_POLICY_NOT_ACTION
message: Should not use NotAction in SQS queue policy
resource: aws_sqs_queue_policy
severity: WARNING
assertions:
- key: policy.Statement[].NotAction
op: absent
tags:
- sqs
- id: SQS_QUEUE_POLICY_NOT_PRINCIPAL
message: Should not use NotPrincipal in SQS queue policy
resource: aws_sqs_queue_policy
severity: WARNING
assertions:
- key: policy.Statement[].NotPrincipal
op: absent
tags:
- sqs
- id: IAM_USER
message: IAM User should not have an inline policy (make member of group instead)
resource: aws_iam_user
severity: FAILURE
assertions:
- key: policy
op: absent
tags:
- iam
- id: IAM_USER_POLICY_ATTACHMENT
message: IAM should not have policies attached (make user a member of a group instead)
resource: aws_iam_user_policy_attachment
severity: FAILURE
assertions:
- key: "@"
op: absent
tags:
- iam
# FIXME really want to check that each user appears in at least one group
- id: IAM_USER_GROUP
message: IAM User should be in at least one group
resource: aws_iam_group_membership
severity: FAILURE
assertions:
- key: group
op: present
- key: users
op: not-empty
- id: LAMBDA_PERMISSION_INVOKE_ACTION
message: Lambda permission should not allow lambda:InvokeAction
resource: aws_lambda_permission
severity: WARNING
assertions:
- key: action
op: ne
value: lambda:InvokeFunction
tags:
- lambda
- id: LAMBDA_PERMISSION_WILDCARD_PRINCIPAL
message: Lambda permission should not have wildcard principal
resource: aws_lambda_permission
severity: FAILURE
assertions:
- key: action
op: ne
value: "*"
tags:
- lambda
- id: WAF_WEB_ACL
message: Default action for WAF should not be ALLOW
resource: aws_waf_web_acl
severity: FAILURE
assertions:
- key: default_action.type
op: ne
value: ALLOW
tags:
- waf
- id: ALB_LISTENER
message: ALB listener security checks
resource: aws_alb_listener
severity: FAILURE
assertions:
- key: port
op: eq
value: 443
- key: protocol
op: ne
value: http
options: ignore-case
- key: ssl_policy
op: present
- key: ssl_policy
op: ne
value: ELBSecurityPolicy-2015-05
- key: ssl_policy
op: ne
value: ELBSecurityPolicy-TLS-1-0-2015-04
- key: certificate_arn
op: present
- key: access_logs
op: present
- key: internal # TODO if the default is true, then add an or that checks absent or is-true
op: is-true
- id: AMI
message: AMI security checks
resource: aws_ami
severity: FAILURE
assertions:
- key: ebs_block_device.encrypted
op: is-true
- key: ebs_block_device.kms_key_id
op: present
- id: AMI_COPY
message: AMI security checks
resource: aws_ami_copy
severity: FAILURE
assertions:
- key: ebs_block_device.encrypted
op: is-true
- key: ebs_block_device.kms_key_id
op: present
- id: API_GATEWAY_DOMAIN_NAME
message: API Gateway checks
resource: aws_api_gateway_domain_name
severity: FAILURE
assertions:
- key: "@"
op: has-properties
value: certificate_name,certificate_body,certificate_change,certificate_private_key
- id: INSTANCE
message: Instance checks
resource: aws_instance
severity: FAILURE
assertions:
- or:
- key: ebs_block_device
op: absent
- key: ebs_block_device.encrypted
op: is-true
- id: CLOUDFRONT_DISTRIBUTION
message: CloudFront Distribution checks
resource: aws_cloudfront_distribution
severity: FAILURE
assertions:
- or:
- key: origin.custom_origin_policy
op: absent
- key: origin.custom_origin_policy.origin_protocol_policy
op: eq
value: https-only
- key: default_cache_behavior.viewer_protocol_policy
op: ne
value: allow-all
- key: cache_behavior.viewer_protocol_policy
op: ne
value: allow-all
- key: logging_config
op: present
- id: CLOUDTRAIL
message: CloudTrail checks
resource: aws_cloudtrail
severity: FAILURE
assertions:
- key: kms_key_id
op: present
- id: CODEBUILD_PROJECT
message: CodeBuild Project checks
resource: aws_codebuild_project
severity: FAILURE
assertions:
- key: encryption_key
op: present
- id: CODEPIPELINE
message: CodePipeline checks
resource: aws_codepipeline
severity: FAILURE
assertions:
- key: encryption_key
op: present
- id: DB_INSTANCE
message: DB Instance checks
resource: aws_db_instance
severity: FAILURE
assertions:
- key: storage_encrypted
op: is-true
- key: kms_key_id
op: present
- id: ELB
message: ELB checks
resource: aws_elb
severity: FAILURE
assertions:
- key: access_logs
op: present
- key: listener.lb_port
op: not-in
value: 80,21,23,5900
- id: DMS_REPLICATION_INSTANCE
message: DMS Replication Instance checks
resource: aws_dms_replication_instance
severity: FAILURE
assertions:
- key: kms_key_arn
op: present
- id: EBS_VOLUME
message: EBS Volume checks
resource: aws_ebs_volume
severity: FAILURE
assertions:
- key: encrypted
op: is-true
- key: kms_key_id
op: present
- id: EFS
message: EFS Checks
resource: aws_efs_file_system
severity: FAILURE
assertions:
- key: encrypted
op: is-true
- key: kms_key_id
op: present
- id: ELASTICTRANSCODE_PIPELINE
message: ElasticTranscoderPipeline checks
resource: aws_elastictranscoder_pipeline
severity: FAILURE
assertions:
- key: aws_kms_key_arn
op: present
- id: KINESIS_FIREHOSE_DELIVERY_STREAM
message: KinesisFirehoseDeliveryStream checks
resource: aws_kinesis_firehose_delivery_stream
severity: FAILURE
assertions:
- or:
- key: s3_configuration.kms_key_arn
op: present
- key: extended_s3_configuration.kms_key_arn
op: present
- id: LAMBDA_FUNCTION
message: Lambda checks
resource: aws_lambda_function
severity: FAILURE
assertions:
- key: kms_key_arn
op: present
- id: OPSWORKS_APPLICATION
message: OpsWorks Application checks
resource: aws_opsworks_application
severity: FAILURE
assertions:
- key: enable_ssl
op: is-true
- id: RDS_CLUSTER
message: RDSCluster checks
resource: aws_rds_cluster
severity: FAILURE
assertions:
- key: storage_encrypted
op: is-true
- key: kms_key_id
op: present
- id: REDSHIFT_CLUSTER
message: RedshiftCluster checks
resource: aws_redshift_cluster
severity: FAILURE
assertions:
- key: encrypted
op: is-true
- key: kms_key_id
op: present
- id: S3_BUCKET_OBJECT
message: S3 Bucket Object checks
resource: aws_s3_bucket_object
severity: FAILURE
assertions:
- key: kms_key_id
op: present
- id: SQS_QUEUE
message: SQSQueue checks
resource: aws_sqs_queue
severity: FAILURE
assertions:
- key: "@"
op: has-properties
value: kms_master_key_id,kms_data_key_reuse_period_seconds