ELB priority in use

[AndreyMarchuk]

On 'mu svc deploy devenv' ELB PriorityInUse issue happens.

ElbHttpsHostListenerRule (AWS::ElasticLoadBalancingV2::ListenerRule) CREATE_IN_PROGRESS Resource creation Initiated AwaitFinalStatus ▶ ERROR mu-service-XXX-devenv: ElbHttpHostListenerRule (AWS::ElasticLoadBalancingV2::ListenerRule) CREATE_FAILED Priority '26' is currently in use (Service: AmazonElasticLoadBalancingV2; Status Code: 400; Error Code: PriorityInUse; Request ID: 82936918-b09e-11e8-8810-afb2085f3d7e)

[brentley]

https://docs.aws.amazon.com/cli/latest/reference/elbv2/set-rule-priorities.html

...as long as there are no priority conflicts...

You can't duplicate priority values for rules. This error seems to indicate that there is already a rule given a priority of "26" so building a second rule with the same priority is failing.

[AndreyMarchuk]

That is clear, but in source code it seems to be getting the largest rule id + 1.
So I wonder why this issue is happening.

[brentley]

Does it work if you configure the priority yourself?

[AndreyMarchuk]

It was coming from config, commented out and it's fine.
Would it make sense to validate this within mu before CloudFormation fails on it?

[brentley]

The config is independent of the other potential projects that are deployed, or not yet deployed. Incrementing by one, or manually keeping track "architecturally" seems like the only options.

[AndreyMarchuk]

Right, but it can fail faster if the check is added into mu where Rules are iterated. For example fail if some Rule.priority == workflow.priority even before CF stack is executed.

[cplee]

fixed in #373