Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: allow song uploads #3

Closed
mrmos opened this issue Aug 6, 2022 · 8 comments
Closed

feature request: allow song uploads #3

mrmos opened this issue Aug 6, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@mrmos
Copy link

mrmos commented Aug 6, 2022

hello - just throwing this in here. I expected to be able to load some of my own music into the app to be split

@iffyloop
Copy link
Member

iffyloop commented Aug 6, 2022

Yes - this is a great idea and has been planned since the first version of StemRoller but didn't make it into the release. Several people have been asking for this feature, so I'll try to make time to work on it in the next week. We'll use this issue to track progress and I'll write an update here in the next few days. Thanks for your suggestion!

@iffyloop iffyloop added the enhancement New feature or request label Aug 6, 2022
@iffyloop iffyloop self-assigned this Aug 6, 2022
@mindplay-dk
Copy link

"upload"? I don't understand... I see Python and a Models folder in the 1.4GB (!) unpacked application folder, so I'd assume this all runs locally, right? Not in the cloud or something?

Is it tied to YouTube? Or what is it even searching? Where's the music coming from?

Being able to search and download music from the web seems like it would be a a secondary feature - a nice extra. I would assume it's much simpler to load audio from a local file than search the web for videos and extracting the audio?

Seems odd. 🤷‍♂️

@dangom
Copy link

dangom commented Aug 6, 2022

You can use demucs directly from the terminal. No need to go through stemroller for that.

pip install demucs
demucs song.wav

@iffyloop
Copy link
Member

iffyloop commented Aug 6, 2022

@mindplay-dk by "upload" we are actually referring to splitting a local file, as you anticipated would be most logical, not an actual upload to YouTube. And yes, you are correct that audio is being downloaded from YouTube first and then split locally on your device.
The reason I created StemRoller was to abstract away all the downloading and splitting steps, so anyone can just search a song and split it. It's basically just youtube-dl and Demucs bundled with a GUI.

@dangom thanks for mentioning that. For now, splitting manually with Demucs is the ideal solution until we get a local file GUI in StemRoller.

@iffyloop iffyloop removed their assignment Aug 8, 2022
@alectrocute
Copy link
Contributor

Made a PR for this: #11

Open to suggestions, etc. It's definitely a "quick and easy" solution to at least allow this for now.

@iffyloop
Copy link
Member

iffyloop commented Aug 9, 2022

Exciting! Let's continue discussion in the PR for now...

@iffyloop iffyloop self-assigned this Aug 9, 2022
@iffyloop
Copy link
Member

Feature has been implemented in the develop branch! Will merge it into the next release! Thanks for your help, and if you want to test out the new implementation and provide feedback I'd be happy to hear it. Haven't tested on Mac yet so that'd be helpful if you get the chance.

@iffyloop
Copy link
Member

Implemented in the latest release (1.1.0)! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants