Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonParser: should parse Pipfiles #4

Open
nokome opened this issue Oct 15, 2018 · 5 comments
Open

PythonParser: should parse Pipfiles #4

nokome opened this issue Oct 15, 2018 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nokome
Copy link
Member

nokome commented Oct 15, 2018

The PythonParser should be able to parse Pipfiles https://github.com/pypa/pipfile

@nokome nokome added the enhancement New feature or request label Oct 15, 2018
@nokome nokome added this to the 1.1.0 milestone Oct 15, 2018
@nokome nokome changed the title PythonParser: can parse Pipfile PythonParser: should parse Pipfiles Oct 15, 2018
@nokome
Copy link
Member Author

nokome commented Oct 29, 2018

... or Pipfile.lock if it exists. There's a JS TOML parser (the Pipfile format) and Pipfile.lock is just JSON so, this shouldn't be too difficult.

@giorgiosironi
Copy link

Just to clarify, what is the purpose of parsing the file? It could be treated as a black box for the purposes of just installing the dependencies, as it can be passed directly to pipenv.

@nokome
Copy link
Member Author

nokome commented Nov 1, 2018

@giorgiosironi : yes, that's a good question. The only reason that we do it is so we can generate a meta-data tree (environ.jsonld) containing information on the project's dependencies. From that you could generate a software citation list for your project or publish a more structured, semantic, and language agnostic representation of your project and it's dependencies.

@nokome nokome added the good first issue Good for newcomers label Nov 22, 2018
@nokome nokome removed this from the 1.1 milestone Jun 14, 2019
@remram44
Copy link
Contributor

Also consider supporting pyproject.toml (or poetry.lock), see PEP 518 and Poetry

@nokome
Copy link
Member Author

nokome commented May 20, 2020

Thanks @remram44 👋. Yep agreed, that would be good to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants